search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Add gzip compression config option. #20

Closed jcsackett closed 8 years ago

jcsackett commented 8 years ago

QA:

You must use this with the up to date HEAD of the develop branch of http://github.com/juju/juju-gui.

First build the charm with develop.

JUJU_GUI_BRANCH=/path/to/juju-gui/repo make clean package

Then bootstrap your env of choice and make deploy the charm.

First, confirm that the gzip compression is on--check the network tab in your browser's developer tools. You'll see less data transferred than the full file size for each file.

Turn off gzip compression:

juju set juju-gui gzip-compression=false

Now refresh the gui and in the network tab confirm that you are seeing transfer sizes equal to file sizes, showing that gzip compression is off.

Turn it back on and make sure it's still working.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/10/ Test PASSed.

frankban commented 8 years ago

:+1:

jrwren commented 8 years ago

:+1: QA works. Also confirmed content-encoding:gzip when gzip-compression=true

jcsackett commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/18/ Test PASSed.