juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

add systemd service for deploying on wily+ #24

Closed jrwren closed 8 years ago

jrwren commented 8 years ago

To QA:

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/21/ Test PASSed.

jcsackett commented 8 years ago

Per discussion in IRC, it would be nice if the guiserver config stuff were moved to a separate script that both systemd and upstart can call to minimize the places we have to update when we add options to guiserver.

bac commented 8 years ago

Love the idea of refactoring those scripts. Makes keeping both (The Debian Way) more palatable.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/22/ Test PASSed.

jcsackett commented 8 years ago

:+1: with the notes to at least help maintain the two different scripts. We'll have to find a better, single way for guiserver to get its config.

jujugui commented 8 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/24/ Test FAILed.

jrwren commented 8 years ago

After initially thinking we could easily move this out into a shell script and have upstart or systemd use that shell script, I thought that no, it wouldn't work because we'd lose the nice pid tracking and restart things that we let upstart and systemd do for us. I was wrong. The use of exec works.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/25/ Test PASSed.

bac commented 8 years ago

Nice changes. :+1: No QA

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/26/ Test PASSed.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/27/ Test PASSed.

jrwren commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge