Closed jrwren closed 8 years ago
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/21/ Test PASSed.
Per discussion in IRC, it would be nice if the guiserver config stuff were moved to a separate script that both systemd and upstart can call to minimize the places we have to update when we add options to guiserver.
Love the idea of refactoring those scripts. Makes keeping both (The Debian Way) more palatable.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/22/ Test PASSed.
:+1: with the notes to at least help maintain the two different scripts. We'll have to find a better, single way for guiserver to get its config.
Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/24/ Test FAILed.
After initially thinking we could easily move this out into a shell script and have upstart or systemd use that shell script, I thought that no, it wouldn't work because we'd lose the nice pid tracking and restart things that we let upstart and systemd do for us. I was wrong. The use of exec works.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/25/ Test PASSed.
Nice changes. :+1: No QA
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/26/ Test PASSed.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/27/ Test PASSed.
:shipit:
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge
To QA:
python tests/deploy.py
and http GET returned IP to check it runs on trustypython tests/deploy.py
and http GET the returned IP to check it runs on wily