search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Make juju-gui-charm a fat charm by including the release and jujugui dependencies #26

Closed bac closed 8 years ago

bac commented 8 years ago

The requirement that we deploy in production from Launchpad means we must support a fat charm in version control, abandoning our attempt to simply package the charm and upload directly to github.

bac commented 8 years ago

This branch updates the makefile to not assume releases and jujugui-deps are non-existent but allows the contents to be updated in place by the make package command.

Handling of packaging for precise is a special case as we never want to check in the dependencies it generates as they are different than for the other charms. We will continue to create an temporary set of dependencies and then upload directly to the charmstore and then discard the changes.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/30/ Test PASSed.

mhilton commented 8 years ago

:+1:

frankban commented 8 years ago

:+1: thanks!

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/32/ Test PASSed.

bac commented 8 years ago

Thanks for the reviews @mhilton and @frankban

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge