search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Properly include /ws in the WebSocket template. #31

Closed frankban closed 8 years ago

frankban commented 8 years ago

Also note that a development (unreleased) version of the GUI tarball is now used.

jujugui commented 8 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/43/ Test FAILed.

jcsackett commented 8 years ago

:+1:

Test is failing b/c development gui includes a change to the base_url default. This works fine with the charm as is (it passed QA with the charm) but this test evidently needs to be updated for the new value.

bac commented 8 years ago

:+1: but please change the tarball name to releases/jujugui-2.0.2-dev.tar.bz2

jujugui commented 8 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/45/ Test FAILed.

jujugui commented 8 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/46/ Test FAILed.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/47/ Test PASSed.

frankban commented 8 years ago

Thanks for the reviews! :shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge