juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Propagate Juju response data when logging in via the token. #36

Closed frankban closed 8 years ago

frankban commented 8 years ago

It's not easy to QA this, I already did with quickstart, and hopefully the code and the test are clear enough to be trusted. The logic is that when you log in with a timed token, instead of completely rewriting the original response from Juju, we just add to that, so that information now required by the GUI after login (for instance facades information) is still available.

makyo commented 8 years ago

:+1:

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/54/ Test PASSed.

frankban commented 8 years ago

Thanks for the review Madison! :shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge