search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Add gisf command-line option for guiserver #54

Closed bac closed 8 years ago

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/95/ Test PASSed.

bac commented 8 years ago

QA:

deploy charm ensure you can hit the GUI in the browser juju run --unit juju-gui/0 'cat /usr/local/bin/runserver.sh' ensure no gisf juju set-config juju-gui gisf-enabled=true juju run --unit juju-gui/0 'cat /usr/local/bin/runserver.sh' ensure --gisf

jcsackett commented 8 years ago

:+1:

I'm wondering how this got past QA previously, since that should have caught this issue. Did we accidentally not QA your previous PR?

This definitely supports the idea that we need to rethink the process of adding options to the gui charm; there's a lot of possible break points.

jcsackett commented 8 years ago

QAing now.

makyo commented 8 years ago

:+1:

jcsackett commented 8 years ago

QA OK.

jcsackett commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge

bac commented 8 years ago

Fixed Issue #53

bac commented 8 years ago

The QA on the previous branch was incomplete. It focused on seeing that the option was written to runserver.sh but didn't actually hit the GUI to see that it had started.

Yes @hatched we need a suite of tests that ensure the options we are setting are actually accepted.