search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Fix syntax error, lint target, and formatting. #56

Closed bac closed 8 years ago

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/102/ Test PASSed.

bac commented 8 years ago

The file hook/cached-website-relation-joined has a syntax error that was introduced before 2.1.1 was cut. It is only showing up now in mojo CI since previous runs of CI installed v2.0.3 of the charm before upgrading to 2.1.1. The relation was created under 2.0.3 so this hook was not exercised.

Now we install 2.1.1 from scratch and jenkins fails.

The error would've been caught if our lint target was better crafted. That has been fixed now, which necessitated some formatting changes.

QA:

Deploy the charm and ensure things work. Create a relation like: ["jc-jujugui:cached-website", "jc-apache2:balancer"]

hatched commented 8 years ago

:+1:

jrwren commented 8 years ago

:+1:

frankban commented 8 years ago

:+1:

jrwren commented 8 years ago

QA: OK

I did: bootstrap; deploy cs:apache2; deploy local:juju-gui; add-relation "juju-gui:cached-website" "apache2:balancer"

There was no error. Relation was added.

bac commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge