Update the charm so that it works with xenial.

juju / juju-gui-charm

Charm for Juju GUI.

GNU Affero General Public License v3.0

2 stars 16 forks source link

Update the charm so that it works with xenial. #59

Closed frankban closed 8 years ago

frankban commented 8 years ago

juju-gui is now a multi-series charm.

Additionally:

remove no longer used files, like lbox ones;
remove functional tests, obsolete, no longer run, to be replaced with uitests;
update publishing docs to reflect new publishing model;
delete lots and lots of unused python functions, tests and objects (yay!).

frankban commented 8 years ago

QA:

bootstrap Juju: juju bootstrap --upload-tools lxd lxd;
push this charm in your namespace, from the charm dir: charm push . should output the resulting fully qualified url, like url: cs:~frankban/juju-gui-0 channel: unpublished Alternatively you can just deploy this as a local charm below;
deploy the trusty charm using the url printed above: juju deploy cs:~frankban/juju-gui-0 trusty-gui --series trusty;
also deploy the xenial charm using the url printed above: juju deploy cs:~frankban/juju-gui-0 xenial-gui --series xenial;
check that the GUI works in both incarnations;
bonus points if you set charm options and see that everything is ok in both trusty and xenial;
destroy the controller;
done, thank you!

jujugui commented 8 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/110/ Test FAILed.

jcsackett commented 8 years ago

I have some questions and trivial comments, but this code looks :+1:

Thanks, @frankban.

Beginning QA now.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/111/ Test PASSed.

bac commented 8 years ago

In the Makefile we still have targets for ensure-juju-test and ensure-juju-env which are not referenced by any other target and are not listed in make help. I think they should be removed.

frankban commented 8 years ago

Thanks for the reviews JC and Brad. I removed ensure-juju-* make targets, good catch.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/112/ Test PASSed.

jcsackett commented 8 years ago

QA notes:

GUI deployed successfully in both series.
In both, the icons for trusty-gui and xenial-gui were missing. Given these charms are unpublished and I wasn't logged in, I think this is to be expected.
I was able to deploy new charms from both -- in those cases I did see the icons.
I was able to make and remove relations.
I was able to set both guis to debug mode from the gui, and saw the changes take effect.

QA OK.

frankban commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge