search

juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Remove charm store and JEM API path options. #63

Closed frankban closed 8 years ago

frankban commented 8 years ago

Also rename jem-location to jem-url so that it's more consistent with charmstore-url and other similar values.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/122/ Test PASSed.

hatched commented 8 years ago

:+1: Thanks for this cleanup no qa

bac commented 8 years ago

I checked out https://github.com/juju/juju-gui/pull/1628 to $HOME/git/juju-gui

In this version of juju-gut-charm I ran 

$ JUJU_GUI_BRANCH=$HOME/git/juju-gui make package
$ juju version
2.0-beta7-xenial-amd64
$ juju bootstrap lxd lxd --upload-tools
$ juju deploy . --series=trusty
$ export JUJU_JEM=https://api.staging.jujucharms.com/jem/
$ juju set-config juju-gui jem-url=$JUJU_JEM

I was then able to hit the juju-gui deployed by the charm and see my existing models that I already had running. I removed the models from the controller, reloaded the GUI, and saw they were gone.

So it seems the configuration settings for the gui and the charm have been changed and work together.

Thanks!

frankban commented 8 years ago

Thanks for the reviews! :shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge