juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Use tornado/upstart config mechanisms rather than production.ini #9

Closed jcsackett closed 8 years ago

jcsackett commented 8 years ago

QA:

In your env of choice: make deploy or deploy as a local charm. Confirm the gui works as expected--search, inspector, machine view, deploys, etc.

bac commented 8 years ago

make lint fails

bac commented 8 years ago

This looks great. :+1: Will QA shortly.

bac commented 8 years ago

QA-OK. I 'juju set' the debug values back and forth and saw the upstart file change. Everything worked as expected.

jcsackett commented 8 years ago

@bac Thanks, I'll fix the lint issues that were exposed and then get this landed.

jcsackett commented 8 years ago

Everything appears to be sorted. Landing.