search

juju / juju-gui

Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.
Other
182 stars 85 forks source link

Charm icon masks are offset by one or two pixels in firefox/Chrome #1322

Closed makyo closed 8 years ago

makyo commented 8 years ago
juju_admin
hatched commented 8 years ago

This also happens in the machine view in Chrome it's because of the border radius used to make everything a circle. Of course the proper fix would be to update the icons to be round instead of squircles with the drop shadow.

anthonydillon commented 8 years ago

We need the squircles to be displayed everywhere instead of on the canvas. So I think we need to just fix this crop instead of adding another image to the API.

Might be worth confirming with design.

On Mon, 8 Feb 2016 at 08:26 Jeff Pihach notifications@github.com wrote:

This also happens in the machine view in Chrome it's because of the border radius used to make everything a circle. Of course the proper fix would be to update the icons to be round instead of squircles with the drop shadow.

— Reply to this email directly or view it on GitHub https://github.com/juju/juju-gui/issues/1322#issuecomment-181252615.

makyo commented 8 years ago

@anthonydillon Oh, yes, I mean the crop, not the icon itself. I'll update the title with that