search

juju / juju-gui

Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.
Other
182 stars 85 forks source link

Investigate not opening a popup for logging in #2438

Closed frankban closed 5 years ago

frankban commented 7 years ago

We should provide a better authentication experience, and this is high priority for dax.

hatched commented 7 years ago

When doing the initial login I see no reason why we can't redirect as there is no state to preserve. We can also do the same for the on-canvas login button if the ecs is empty. Then we're only left with the DF requiring a popup until we can come up with a quality solution for storing and then re-importing the user state.

WRT the DF login: Now that we can export bundles with uncommitted state we can potentially export the state as a bundle, store it in local storage, then re-import it. The downside to this is that depending on the complexity of what is on the canvas this re-import can take considerable time (see openstack) and we'd want to then load them back into the deployment flow. This process would likely require some UI work to show that it's "working". In this case I don't feel like the popup is very inconvenient compared to the former.

I propose that the first step forward here is to implement the redirect for the two known-ok spots and leave the DF login.

frankban commented 7 years ago

+1, we can gradually improve later, but starting with the easy cases sounds good.

Lukewh commented 7 years ago

Related https://github.com/juju/juju-gui/issues/2502

hatched commented 7 years ago

With the new UI enhancements this has been deferred.

frankban commented 6 years ago

I'll put this on the roadmap as candid is gonna support this soon.