Format all .js files using Prettier

barrymcgee commented 6 years ago

Please review https://github.com/juju/juju-gui/pull/3863 before this PR

I'm going to split this task into two PRs, one for Sass and one for Javascript.

This PR is JS only.

Each branch will use the same Prettier config file. That is;

{
  "bracketSpacing": false,
  "singleQuote": true,
  "printWidth": 95
}

I've removed redundant formatting rules from .eslintrc as Prettier takes care of these.
As with the Sass PR, I recommend uping the printWidth config to 120 which will decrease the number of wrapping code lines and overall changes.
I've haven't used any // prettier-ignore flags in this PR.

hatched commented 6 years ago

The rational behind the line length limit is to keep the lines short enough so you can have multiple files side by side on laptop screens. You don't increase that and reduce the legibility to serve some formatting tool :)

barrymcgee commented 6 years ago

For the conclusion to this discussion, please see https://github.com/juju/juju-gui/pull/3863#issuecomment-436338292

Thank you all 🙏🏻

juju / juju-gui

Format all .js files using Prettier #3864

Please review https://github.com/juju/juju-gui/pull/3863 before this PR