search

juju / juju-gui

Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.
Other
182 stars 85 forks source link

Serve the GUI from flask instead of pyramid. #3908

Closed hatched closed 5 years ago

hatched commented 5 years ago

This branch enables serving the GUI from a flask app instead of a pyramid one.

This is the first step in converting the file structure of the GUI over.

Fixes https://github.com/ubuntudesign/juju-squad/issues/562

nottrobin commented 5 years ago

Really nice quick work so far @hatched, thanks!

I left a few comments inline, just push back on or ignore any of them that don't make sense.

One QA issue - static images don't seem to be loading properly (seems to be looking for /static/static/..., which may be the problem):

static-error

There's another issue with the "view all the charms" endpoint at http://localhost:8000/q/store, which seems to end up in an infinite loop, but the same issue seems to be there on live, so it's probably not Flask's fault: https://jujucharms.com/q/store/?type=charm.

hatched commented 5 years ago

Thanks for the review @nottrobin !

Good find with those images, I'll update those and the rest of them with the same issue.

The looping request has been fixed in develop, so you're right not part of this branch :)

hatched commented 5 years ago

I'm going to stop working on getting this travis build to pass and instead, in a follow-up, move it over to circle.

@nottrobin would you mind taking another look so that this can land?