Add k8s label styling - Githubissues

juju / juju-gui

Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.

Other

182 stars 85 forks source link

Add k8s label styling #3935

Closed huwshimi closed 5 years ago

huwshimi commented 5 years ago

Display the series and k8s labels in the store and entity headers with the new styling. Fixes: #3934. Fixes: #3933.

huwshimi commented 5 years ago

QA:

Open /new/q/kubernetes/?type=charm
You should see the series and k8s labels as per https://app.zeplin.io/project/5c5871a14e1897355935afb1/screen/5c9a3bc5be520e781e716534
Click on a k8s charm and non-k8s charm, you should see the series labels in the header as per https://app.zeplin.io/project/5c5871a14e1897355935afb1/screen/5c6bc4e8d8363d9b21f7748f and https://app.zeplin.io/project/5c5871a14e1897355935afb1/screen/5c6bc4e6e66ab39ac1de43b4

hatched commented 5 years ago

https://juju-gui-juju-pr-3935.run.demo.haus/

hatched commented 5 years ago

I unfortunately don't have permission to push to this repo so these updates will have to wait until Huw is back.

huwshimi commented 5 years ago

@spencerbygraves I've updated the spacing, and I check that the border and text colours are both #2e69ea (same as jaas.ai). Would you mind taking another look?

spencerbygraves commented 5 years ago

@huwshimi thanks, looks good now 👍