juju / persistent-cookiejar

cookiejar is a fork of net/http/cookiejar that allows serialisation of the stored cookies
BSD 3-Clause "New" or "Revised" License
112 stars 75 forks source link

revert back to file-based locking; increase timeout #21

Closed rogpeppe closed 7 years ago

rogpeppe commented 7 years ago

We want to use file-based locking because we're locking a file. Non-file-based locking can't work when locking on a shared filesystem.

We also increase the timeout to because some users have reported timeout errors.

mhilton commented 7 years ago

assuming you want to revert the change, then this looks like a good way to do it. LGTM

voidspace commented 7 years ago

LGTM