search

juju / persistent-cookiejar

cookiejar is a fork of net/http/cookiejar that allows serialisation of the stored cookies
BSD 3-Clause "New" or "Revised" License
112 stars 75 forks source link

Use file-based locking when persisting cookies. #4

Closed dullgiulio closed 8 years ago

dullgiulio commented 9 years ago

This is a proposal for file-based locking and merging when persisting cookies.

Tests and docs are missing. I'd add them when the overall implementation is finalized.

Let me know if there are major flaws.

mhilton commented 8 years ago

Thanks @dullgiulio for this, it looks like a nice start. I've commented on a few things that might need some thought. Also as you pointed out it could do with documentation and tests.

rogpeppe commented 8 years ago

Superceded by PR #6