Forward port latest changes from 2.9 onto 3.x

juju / python-libjuju

Python library for the Juju API

Apache License 2.0

59 stars 99 forks source link

Forward port latest changes from 2.9 onto 3.x #1022

Closed cderici closed 7 months ago

cderici commented 7 months ago

Description

This brings onto the 3.x track some of the latest fixes from to the 2.9 track. Here're the details:

Fix for #989 from #990
Fix for #1001 from #1002
Fix for #998 from #1003

QA Steps

No QA needed for #990. For 1002 and 1003 please refer to their QA steps. Though they are very related so I'd expect the QA for both of them can be done in one fell swoop.

1002
1003

All CI tests need to pass (there's still some known intermittent ones in there).

cderici commented 7 months ago

Provided the integration test failures are known failures, LGTM

yeah just tried them locally they pass 👍 thanks for the review!

cderici commented 7 months ago

/merge