Closed Aflynn50 closed 3 months ago
Code looks good. Could you please check if there's a test with a controller name in the endpoint url? If not we should add that (for
parse_offer_url
, or_get_source_api
) I'd be ok if it's a mocked test withintests/unit
if coming up with a sensible integration test is hard. We just need to ensure the capability is there for future. Hope that makes sense.Also looks like we need a rebase.
I've added a unit test which checks the consume behavior, though its uses a lot of mocks.
I've also changed it so you can use the controller_name argument as expected, just to ensure that we don't break anything with this.
/merge
Description
consume
takes acontroller_name
argument. This is not needed and should be automatically generated from the offer url. A deprecation warning is logged and the variable is not used.Also update offer and consume integration tests to no longer be skipped.
This helps avoid #1031
QA Steps
All CI tests need to pass.