search

juju / python-libjuju

Python library for the Juju API
Apache License 2.0
59 stars 99 forks source link

when deploying a bundle, resource revisions are ignored #273

Closed Cynerva closed 5 years ago

Cynerva commented 5 years ago

Deploy a bundle that includes something like this:

services:
  flannel:
    charm: cs:~containers/flannel-339
    resources:
      flannel-amd64: 3
      flannel-arm64: 1
      flannel-s390x: 3

Instead of getting the specified bundle revisions, you'll get whichever revisions the charm store gives you (in this case, the latest resources from the edge channel). In contrast, if you deploy via Juju CLI, you will get the specified revisions.

The issue occurs here, where the resources that are passed in do include the revision numbers, but that parameter is ignored.

johnsca commented 5 years ago

Specifically, I think this needs to honor resource IDs that are already given and only use the ones from the store which are not explicitly specified.