search

juju / terms-client

Terms service client
Other
0 stars 7 forks source link

Rename publish-term to release-term. #10

Closed cmars closed 8 years ago

cmars commented 8 years ago

Only renaming things from a CLI UX perspective. It's not worth renaming "publish" to "release" everywhere in the API over this.

alesstimec commented 8 years ago

It has been done already.. At least i think i had a pr for that..

Sent from my iPhone

On 29 Aug 2016, at 20:45, Casey Marshall notifications@github.com wrote:

Only renaming things from a CLI UX perspective. It's not worth renaming "publish" to "release" everywhere in the API over this.

You can view, comment on, or merge this pull request online at:

https://github.com/juju/terms-client/pull/10

Commit Summary

Rename publish-term to release-term. File Changes

R cmd/charm-release-term/main.go (2) M cmd/cmd_test.go (6) M cmd/publish_term.go (28) Patch Links:

https://github.com/juju/terms-client/pull/10.patch https://github.com/juju/terms-client/pull/10.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

cmars commented 8 years ago

@alesstimec Was that plans-client?

alesstimec commented 8 years ago

@cmars: ah, right! That was the plans api and client!

Sent from my iPhone

On 29 Aug 2016, at 21:22, Casey Marshall notifications@github.com wrote:

@alesstimec Was that plans-client?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

tasdomas commented 8 years ago

lgtm

mattyw commented 8 years ago

Weren't we also going to change the api client to use Release instead of Publish?

cmars commented 8 years ago

@mattyw Long term, perhaps. Short-term, there's no tangible benefit.

$$merge$$

ghost commented 8 years ago

Status: merge request accepted. Url: http://10.55.60.189:8080/job/terms-client-merge/buildWithParameters