Basic tests for TimeRFC3339 (un)marshaling.

juju / terms-client

Terms service client

Other

0 stars 7 forks source link

Basic tests for TimeRFC3339 (un)marshaling. #3

Closed alesstimec closed 8 years ago

mattyw commented 8 years ago

LGTM - but do we need TimeRFC3339 unmarshalling? It's a struct we probably should just be getting rid off

cmars commented 8 years ago

LGTM.

We need to keep the TimeRFC3339 type to maintain control over our wireformat representation of timestamps. For example, we don't want to output subsecond resolution, or arbitrary timezones.

alesstimec commented 8 years ago

$$merge$$

ghost commented 8 years ago

Status: merge request accepted. Url: http://10.55.60.189:8080/job/terms-client-merge/buildWithParameters