Assign non-empty `client_id` to `username`

juju / terraform-provider-juju

A Terraform provider for Juju

Apache License 2.0

19 stars 32 forks source link

Assign non-empty `client_id` to `username` #475

Closed babakks closed 1 month ago

babakks commented 2 months ago

Description

While QA-ing the rc0.12.0, we noticed an error complaining about empty username field. Actually, when the client_id is already assigned, the username has to be empty, and there should be no error. In this PR, username is assigned to the client_id value, whenever the client_id is not empty.

Fixes:

Type of change

Bug fix (non-breaking change which fixes an issue)

Environment

Juju controller version: 3.5-rc1
Terraform version: 1.8.2-dev

hmlanigan commented 1 month ago

The plan is to fix this in juju 3.5.1 apis, then once released pull into the next terraform release. 3.5.1 is planned for 10-Jun.

The juju pr to fix is: https://github.com/juju/juju/pull/17309