Closed marcoceppi closed 8 years ago
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/66/ Test PASSed.
:+1:
Could you add some comments to the changes so that future us knows why it's a range?
Thanks @hatched I've updated the versions to be more inclusive. This will cover every version of python-requests from trusty to xenial
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/67/ Test PASSed.
== is never helpful in the context of packages - setting a minimum version is good tho - could we apply the same policy to all versions please? I think enforcing an upper limit should only be applied if there is a problem.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/71/ Test PASSed.
On our projects we've gotten into the habit of specifying versions exactly, since we're installing from a download cache. For general use libraries like this one it is a mistake.
I like @javacruft's suggestion to provide minimum versions and drop the upper bound. I'd not expect that to happen in this change, though.
:+1: with that change on requests only.
@bac I've dropped upper bands and replaced all == with >= - thanks for the feedback
:+1: ty
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/72/ Test PASSed.
This fixes the following traceback which will happen to any user or package using theblues.
fixes #21