Closed fabricematrat closed 8 years ago
QA
python
from theblues.plans import Plans from jujubundlelib import references p = Plans("http://api.jujugui.org/omnibus/v2") ref = references.Reference.from_string('cs:trusty/landscape-mock-0') p.get_plans(ref)
from theblues.terms import Terms t = Terms("http://api.jujugui.org/terms/v1") t.get_terms("canonical")
Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/119/ Test FAILed.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/120/ Test PASSed.
@fabricematrat This looks pretty good to me--I have some concerns about the namedtuple declaration, but I'm not sure what you did was wrong. It just doesn't quite match the docs. It does look like your tests should fail if the declarations are wrong but we can see that they're passing. So I guess this is a "assuming what I wrote works, I would prefer it, but I can't be sure it's wrong so take it or leave it".
Thanks.
:+1: assuming the tuple issue isn't actually an issue.
:+1: with some changes, only minor stuff. Thank you!
QA is :ok:, thanks @fabricematrat!
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/121/ Test PASSed.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/122/ Test PASSed.
:shipit:
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/118/ Test PASSed.