search

juju / theblues

Python library for the juju charmstore (v4)
GNU Lesser General Public License v3.0
5 stars 22 forks source link

Provide default charm store URL #46

Closed johnsca closed 7 years ago

johnsca commented 7 years ago

Supports overriding the default URL for backwards compatibility.

Fixes #45

jujugui commented 7 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/159/ Test PASSed.

pengale commented 7 years ago

LGTM/+1 (disregard the earlier version of this comment complaining about formatting in the tests.)

johnsca commented 7 years ago

Simplified the diff based on review.

jujugui commented 7 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/162/ Test PASSed.

howbazaar commented 7 years ago

:shipit:

jujugui commented 7 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge