juju / theblues

Python library for the juju charmstore (v4)
GNU Lesser General Public License v3.0
5 stars 22 forks source link

Add simple usage example to README. #5

Closed jcsackett closed 9 years ago

jcsackett commented 9 years ago

QA:

Verify that the example provided actually works for you.

jujugui commented 9 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/6/ Test PASSed.

fabricematrat commented 9 years ago

:+1: with minor comments. For future ref, I think we need to think not only about methods docs but also the data format so people knows where to find things.

bac commented 9 years ago

:+1: and they all work! QA-OK

jcsackett commented 9 years ago

@fabricematrat thanks for the review! I've addressed your comments, I think.

For future ref, I think we need to think not only about methods docs but also the data format so people knows where to find things.

I concur. I'm hoping we have public charmstore docs at some point covering that we can point to from theblues docs, rather than reproducing all of that information, but either way we need it.

This also raises the point that our library right now is little more than a wrap around a standard GET on the charmstore--at some point we may want to consider a higher level module that provides a nicer, more intuitive object.

jcsackett commented 9 years ago

@bac Thanks for the review and the QA.

jujugui commented 9 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/7/ Test PASSed.

jcsackett commented 9 years ago

Thanks again @fabricematrat and @bac. :shipit:

jujugui commented 9 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge