Closed jcsackett closed 9 years ago
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/6/ Test PASSed.
:+1: with minor comments. For future ref, I think we need to think not only about methods docs but also the data format so people knows where to find things.
:+1: and they all work! QA-OK
@fabricematrat thanks for the review! I've addressed your comments, I think.
For future ref, I think we need to think not only about methods docs but also the data format so people knows where to find things.
I concur. I'm hoping we have public charmstore docs at some point covering that we can point to from theblues docs, rather than reproducing all of that information, but either way we need it.
This also raises the point that our library right now is little more than a wrap around a standard GET on the charmstore--at some point we may want to consider a higher level module that provides a nicer, more intuitive object.
@bac Thanks for the review and the QA.
Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/theblues-lib/7/ Test PASSed.
Thanks again @fabricematrat and @bac. :shipit:
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge
QA:
Verify that the example provided actually works for you.