Wrong quote parsing in nicknames

juju2143 / walrusirc

Alternate client for OmnomIRC

http://codewalr.us/194

GNU General Public License v3.0

1 stars 1 forks source link

Wrong quote parsing in nicknames #5

Closed Eiyeron closed 9 years ago

Eiyeron commented 9 years ago

The title says all. If one user have quotes/double quotes in the nickname, they're wrongly escaped into html code

Duke "Eiyeron" tape

Will be converted to

Duke "Tape" Eiyeron

juju2143 commented 9 years ago

The nickname is escaped twice, once by SMF and once by the WalrusIRC client. The same bug also happens in OmnomIRC and is even part of the protocol specification. I already have some sort of fix on the client (that I should commit soon), but @Sorunome suggested it should be done at the checkLogin.php level (that is, unescaping it there and re-escaping it in the client), so I guess we'll see what he will do.

juju2143 commented 9 years ago

Sorunome/OmnomIRC2@2ed8bbc6000fe3bb6069aeb8da772d05406062a4 is probably gonna fix it, so I won't bother commiting that change for now.