jukibom / FlyDangerous

A love letter to the Elite Dangerous racing community ❤
https://store.steampowered.com/app/1781750/Fly_Dangerous/
GNU General Public License v3.0
273 stars 24 forks source link

Hiding mass and inetriaTensorMultiplier from ship config settings, and possibly adding boostReverseEffectiveness. #250

Open CardamomCake opened 6 months ago

CardamomCake commented 6 months ago

Mass and inetriaTensorMultiplier are redundant in the flight model outside collisions, so hiding them as editable in the settings might be a good idea in order to make different configs more easily comparable to each other.

boostReverseEffectiveness would influence how much you can counteract the forced forward thrust from boosting, the default now is a hard-coded 40% if I remember correctly.

I think adding the option for boostReverseEffectiveness makes sense because the there are many options for tweaking almost every aspect of how the boost works. This is like the only mayor part of the flight model that has no option to tweak it that I can think of.

Thoughts?

P.S. I am willing to try to do this issue myself, but in that case I could use some directions to the files which would need tweaking.

jukibom commented 6 months ago

IIRC also the spool-up time of 1 second is hardcoded (that'll be a much bigger pain to change with sound effects and multiplayer event signals involved!)

CardamomCake commented 6 months ago

I did see that in the code. Is the hard-coding of the spool-up time because of the countdown of races, or is there some deeper reason for that?

jukibom commented 6 months ago

That's certainly a part of it, yeah - I don't really know a good way to make that easily configurable. It can be done it'll just be gross

CardamomCake commented 6 months ago

I think I already found the files for that matter for the normal ship config stuff. I'd like to take a crack at this issue if that's okay with you.

jukibom commented 6 months ago

of course, go for it