search

jukylin / jaeger-php

Jaeger Bindings for PHP OpenTracing API
https://github.com/jaegertracing/jaeger
Apache License 2.0
225 stars 81 forks source link

"minimum-stability": "dev" => to stable #92

Closed quebello closed 4 years ago

quebello commented 4 years ago

Hello,

Is it possible to do a release with the "minimum-stability": "stable" ? and when you can do that ?

Kind regards

weixuan19930 commented 4 years ago

+1

jukylin commented 4 years ago

Sorry for late reply. Actually, I wanted to release a stable version for a long time, It's just that I need to wait for opentracing-php release stable version first. Done v2.1.3

quebello commented 4 years ago

@jukylin thank you

The opentracing-php package has a stable version => Version 1.0.0-beta6 https://github.com/opentracing/opentracing-php/releases/tag/1.0.0-beta6 (as you can see the composer.json https://github.com/opentracing/opentracing-php/blob/1.0.0-beta6/composer.json)

quebello commented 4 years ago

@jukylin when an update , please?

jukylin commented 4 years ago

Wath do you mean ? I have released a stable version v2.1.3

quebello commented 4 years ago

In your version 2.1.3, you use the version "opentracing/opentracing" : "1.0.0-beta5" But this one use a minimum stability dev.

With the Version 1.0.0-beta6 => the minimum stability is stable !!! Then you can switch in you composer to this version no ?

jukylin commented 4 years ago

1.0.0-beta5 version is stable too. 1.0.0-beta5/composer.json

dmnbars commented 4 years ago

if I understand the documentation correctly 1.0.0-beta* versions is not stable. Only 1.0.0 would be stable.

dmnbars commented 4 years ago

config minimum-stability in root composer.json only for install deps of current package: https://getcomposer.org/doc/04-schema.md#minimum-stability

quebello commented 4 years ago

In my composer.json

  "minimum-stability": "stable",
  "require": {
    "guzzlehttp/guzzle": "^6.5",
    "illuminate/support": "^6.0",
    "jukylin/jaeger-php": "2.1.3",
    "rtbf/lumen-support": "^2.0"
  },

$ composer install Loading composer repositories with package information Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for jukylin/jaeger-php 2.1.3 -> satisfiable by jukylin/jaeger-php[v2.1.3].
    - jukylin/jaeger-php v2.1.3 requires opentracing/opentracing 1.0.0-beta5 -> satisfiable by opentracing/opentracing[1.0.0-beta5] but these conflict with your requirements or minimum-stability.
quebello commented 4 years ago

Ok it works if i had this in the composer.json

    "jukylin/jaeger-php": "2.1.3",
    "opentracing/opentracing": "1.0.0-beta5",