Open julealgon opened 2 years ago
Interesting :)
Edit: From the change log:
Shortcuts to town will only be open if the hero has visited them at least once from inside the dungeon Monsters will keep attacking the hero's body when you die
I belive this was already the case from Diablo 1.00 to DevilutionX 1.3.0?
Interesting :)
:)
Edit: From the change log:
Shortcuts to town will only be open if the hero has visited them at least once from inside the dungeon Monsters will keep attacking the hero's body when you die
I belive this was already the case from Diablo 1.00 to DevilutionX 1.3.0?
Both were behaviors controlled by the isHellfire
flag.
Ok, I guess the statement is in contrast to Hellfire then. I was reading things more in a "Diablo with some Hellfire additions" context.
Ok, I guess the statement is in contrast to Hellfire then. I was reading things more in a "Diablo with some Hellfire additions" context.
Ah sure. Yeah the list is basically what has changed in relation to DevilutionX. In that context of Diablo and Hellfire modes, we are basically saying "this won't depend on Hellfire vs Diablo anymore and the unified behavior is X" for each specific behavior that was previously toggled.
I figured I'd document this early since I'm pretty sure people will end up asking at some point (even though I think most of these will end up being heavily impacted by other changes later).
@julealgon did you see the PRs I opened? Should be able to reduce the code base by another 1000 lines together.
@julealgon did you see the PRs I opened? Should be able to reduce the code base by another 1000 lines together.
To be honest I've been ignoring most refactoring PRs upstream at this point. If you want to explicitly mention them I could look into potentially integrating but otherwise I'll just plow through everything during the conversion (which I've already started).
They are not upstream... https://github.com/julealgon/DiabloCore/pull/34 https://github.com/julealgon/DiabloCore/pull/33 https://github.com/julealgon/DiabloCore/pull/32 https://github.com/julealgon/DiabloCore/pull/31 https://github.com/julealgon/DiabloCore/pull/30 https://github.com/julealgon/DiabloCore/pull/29
@julealgon yes, no, maybe?
@julealgon yes, no, maybe?
Sorry I didn't get back to you, have not touched the fork in the past couple weeks. Will let you know next time I get back to it.
The README reads as the dream coming true. The exact design philosophy that would turn this game into a masterpiece, a better game than the most of even modern titles. Sadly, the project appears abandoned. Is there anything that could help you with turning it into reality?
The README reads as the dream coming true. The exact design philosophy that would turn this game into a masterpiece, a better game than the most of even modern titles.
Glad you like some of the proposals @odragora 😊
Sadly, the project appears abandoned. Is there anything that could help you with turning it into reality?
Sorry about that. I wanted to get back to this but had some IRL issues recently that impacted my motivation a bit. I did some investigation on a few things but outside of this repo to test some ideas. I'll most likely go back to it by the end of the year, but I just can't promise any ETA on actual completion or even partial completion of the implementation.
Do note that I'm 100% active in terms of reading these notifications and catching up with DevilutionX though.
This issue will serve as documentation for all the specific changes I want to make in the mod. For now, they are not very well organized. Each topic will eventually have its own dedicated issue to elaborate on the change a bit more (and keep this post cleaner).