Add a finder for Alma Linux

[0xDEC0DE]

A sensibly-distributed little RPM-based distro:

https://repo.almalinux.org/

This finder tries to take the best bits from the UBI, CentOS, and Photon OS finders to make something small, no-nonsense, and performant.

Drive-by: banish all now-unused nosec markers, and references to silly things Bandit used to do.

Fixes: Issue #40

---

This change is 

[0xDEC0DE]

soufi/finders/alma.py line 33 at r1 (raw file):

Previously, juledwar (Julian Edwards) wrote…

XML. Someone kill it now please.

Worse, it's XPath! :laughing:

[0xDEC0DE]

soufi/tests/finders/test_alma_finder.py line 87 at r1 (raw file):

Previously, juledwar (Julian Edwards) wrote…

Maybe worth checking these are generators? Maybe not, up to you.

I don't think it is.

[0xDEC0DE]

soufi/tests/finders/test_alma_finder.py line 29 at r1 (raw file):

Previously, juledwar (Julian Edwards) wrote…

This exact same code is in a few places - it would be taken as a kindness to move it to the factory. Bonus points for including it in a custom patch method that does everything in a one-liner call (similar to what we do in our other projects).

I will do this as a follow-on commit.

[0xDEC0DE]

soufi/functional/test_functional.py line 280 at r1 (raw file):

Previously, juledwar (Julian Edwards) wrote…

I'd honestly prefer multi-line continuation strings over bypassing the linter.

It is FAR less readable. And in context, this is a big, dumb text slug anyhow...

[juledwar]

soufi/testing/base.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

Yer missed one

[juledwar]

soufi/tests/finders/test_centos_finder.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

Another!

[juledwar]

soufi/tests/finders/test_gem_finder.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

Guess what

[juledwar]

soufi/tests/finders/test_golang_finder.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

Heyo

[juledwar]

soufi/tests/finders/test_java_finder.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

lol

[juledwar]

soufi/tests/finders/test_npm_finder.py line 1 at r3 (raw file):

# Copyright (c) 2021 Cisco Systems, Inc. and its affiliates

I give up

[0xDEC0DE]

soufi/testing/base.py line 1 at r3 (raw file):

Previously, juledwar (Julian Edwards) wrote…

Yer missed one

Oh, I only put this year's copyright on the new files, since they were added this year.

Do you really want to roll the copyright on every file? Or just the files I've touched?

And should we therefore be rolling the copyright on every modification? Seems extreme.

[juledwar]

As I understand things from the legal team, we have to keep the copyright year current on any files we touch.