Closed GoogleCodeExporter closed 8 years ago
Original comment by fbarch...@chromium.org
on 15 Dec 2015 at 5:36
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/77346fcb4a6ffb81c70400e9b7417bc1d4ce5a4f
commit 77346fcb4a6ffb81c70400e9b7417bc1d4ce5a4f
Author: Frank Barchard <fbarchard@google.com>
Date: Tue Dec 15 05:36:12 2015
disable I411ToARGB assembly if _DEBUG for chromium, as well as DEBUG for other
builds.
TBR=harryjin@google.com
BUG=libyuv:533
Review URL: https://codereview.chromium.org/1527903002 .
[modify]
http://crrev.com/77346fcb4a6ffb81c70400e9b7417bc1d4ce5a4f/include/libyuv/row.h
Original comment by bugdroid1@chromium.org
on 15 Dec 2015 at 5:36
Still occurs on Mac Debug 32 bit build:
FAILED: /Volumes/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/source/libyuv.row_gcc.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=247874-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1
-DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDONT_EMBED_BUILD_METADATA
-DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DHAVE_JPEG
-DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen
-I../../include -I../.. -I../../chromium/src/third_party/libjpeg_turbo
-isysroot
/Applications/Xcode6.1.app/Contents/Developer/Platforms/MacOSX.platform/Develope
r/SDKs/MacOSX10.10.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
-mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers
-Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-bitfield-width -std=c++11 -stdlib=libc++
-fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics
-Xclang -load -Xclang
/Volumes/data/b/build/slave/mac32/build/src/third_party/llvm-build/Release+Asser
ts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang
find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang
check-templates -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all
-Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -c
../../source/row_gcc.cc -o obj/source/libyuv.row_gcc.o
../../source/row_gcc.cc:1809:5: error: inline assembly requires more registers
than available
"sub %[u_buf],%[v_buf] \n"
^
../../source/row_gcc.cc:1809:5: error: inline assembly requires more registers
than available
2 errors generated.
ninja: build stopped: subcommand failed.
/usr/bin/python /Volumes/data/b/build/goma/goma_ctl.py jsonstatus
/tmp/tmp6OaphB.json
Original comment by fbarch...@chromium.org
on 16 Dec 2015 at 6:50
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/029f926a14102a99b9b92ccd040be34adaec64da
commit 029f926a14102a99b9b92ccd040be34adaec64da
Author: Frank Barchard <fbarchard@google.com>
Date: Thu Dec 17 00:23:09 2015
add NDEBUG for release chromium buids
BUG=libyuv:533
TBR=harryjin@google.com
Review URL: https://codereview.chromium.org/1531143002 .
[modify]
http://crrev.com/029f926a14102a99b9b92ccd040be34adaec64da/README.chromium
[modify]
http://crrev.com/029f926a14102a99b9b92ccd040be34adaec64da/include/libyuv/row.h
[modify]
http://crrev.com/029f926a14102a99b9b92ccd040be34adaec64da/include/libyuv/version
.h
Original comment by bugdroid1@chromium.org
on 17 Dec 2015 at 12:24
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/1ccbf8fb7b1d84d37eabb26de933f841daf0ade7
commit 1ccbf8fb7b1d84d37eabb26de933f841daf0ade7
Author: Frank Barchard <fbarchard@google.com>
Date: Thu Dec 17 01:13:37 2015
use memory for loop counter to work around nearly out of registers
TBR=harryjin@google.com
BUG=libyuv:533
Review URL: https://codereview.chromium.org/1535433003 .
[modify]
http://crrev.com/1ccbf8fb7b1d84d37eabb26de933f841daf0ade7/source/row_gcc.cc
Original comment by bugdroid1@chromium.org
on 17 Dec 2015 at 1:14
Original comment by fbarch...@google.com
on 17 Dec 2015 at 1:15
Original issue reported on code.google.com by
fbarch...@chromium.org
on 15 Dec 2015 at 5:31