style: use const reference when decoding `std::vector<jule::I32>` - Githubissues

julelang / jule

Effective programming language to build efficient, fast, reliable and safe software while maintaining simplicity

https://jule.dev

BSD 3-Clause "New" or "Revised" License

128 stars 13 forks source link

style: use const reference when decoding `std::vector<jule::I32>` #62

Closed vil02 closed 7 months ago

vil02 commented 7 months ago

Description

Altough utf16_decode for std::vector<jule::I32> is not yet defined, I think the input of that function should be passed by const reference.

Checklist

[x] A description of the changes in this PR is mentioned above.
[x] All the new and existing tests pass.
[x] The code follows the code style and conventions of the project.
[x] No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
[x] I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Avoid passing std::vector<jule::I32> by value.