Comparing signed and unsigned ints can lead to all kinds of madness and it should be avoided. Please note that on two occasions I have used decltype, which might be an overkill. I can change it to std::size_t.
Checklist
[x] A description of the changes in this PR is mentioned above.
[x] All the new and existing tests pass.
[x] The code follows the code style and conventions of the project.
[x] No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
[x] I have read the whole Contributing guidelines of the project and its resources/related pages.
Description
Comparing signed and unsigned ints can lead to all kinds of madness and it should be avoided. Please note that on two occasions I have used
decltype, which might be an overkill. I can change it tostd::size_t.Checklist
Screenshots (if any)
Note to reviewers
Avoid comparison of integers of different sign.