search

julesfern / spahql

A query language for Javascript data. Extracted from Spah.
MIT License
325 stars 20 forks source link

remove global leaks #12

Closed jessejlt closed 10 years ago

jessejlt commented 12 years ago

gleaks found some global variable leaks while I was executing some tests, the fixes are attached.

julesfern commented 12 years ago

Hi Jesse - thanks for the pull request! I'm crazy busy for the next week or so, but I promise to get this reviewed as soon as I've got a little time free. I certainly don't want to be ungrateful for your contribution!

jessejlt commented 12 years ago

Not a problem, friend!

-jesse

On Wed, Oct 17, 2012 at 2:58 AM, Dan Glegg notifications@github.com wrote:

Hi Jesse - thanks for the pull request! I'm crazy busy for the next week or so, but I promise to get this reviewed as soon as I've got a little time free. I certainly don't want to be ungrateful for your contribution!

— Reply to this email directly or view it on GitHubhttps://github.com/danski/spahql/pull/12#issuecomment-9521966.

jessejlt commented 11 years ago

Would be much appreciated if you could merge this :octocat:

julesfern commented 10 years ago

And @bohtvaroh has just reminded me that I forgot this PR completely, despite my promise not to do so. If I recall what I was doing a year ago, it would have been changing jobs and preparing to move home - but, nevertheless, my responsibility. I can only apologize, Jesse - I dropped the ball, and that was not cool of me.

I'll close this out, as it doesn't quite work with the way SpahQL is built right now - you've made a change to the generated javascript, not the source files - and the way SpahQL is build should be modernized in a revision regardless. I'll add an issue for the underlying problem. Again, my apologies for dropping this.