search

julesfern / spahql

A query language for Javascript data. Extracted from Spah.
MIT License
325 stars 20 forks source link

Fixes for issue #22 #30

Closed bedney closed 9 years ago

bedney commented 9 years ago

This fixes the problems encountered when using SpahQL with libraries that extend (i.e. monkey patch) built-in prototypes, like Array. This should fix issue #22 . It is, admittedly, a pretty brute force approach, but best practices around for...in loops these days is to check with hasOwnProperty.

bedney commented 9 years ago

It looks like this may also fix issue #14.

julesfern commented 9 years ago

Sorry for letting this sit - I was trying to think of a better approach but ultimately, SpahQL's source is a little dusty right now and could benefit from a serious ES6 upgrade. Let's go ahead and merge this - thanks so much for the contribution!