search

julesfern / spahql

A query language for Javascript data. Extracted from Spah.
MIT License
325 stars 20 forks source link

toString and valueOf #7

Closed dfellis closed 12 years ago

dfellis commented 12 years ago

Here are the toString and valueOf implementations as I said I'd implement first, as well as tests for their proper behavior.

I have to note that you can't run rake build and get a minified file due to the fact that the indicated .jar file is outside of the repo and it's name is too generic for me to google it.

Can I recommend converting /src/SpahQL.js to require() all of the other js files Node.js-style, then use node-browserify to merge them together and strip the require()s back out, and then use UglifyJS to minify the resulting file? I suggest this because you already require nodeunit for tests so Node.js is needed, and make, rake, and bundle are all superfluous to this Javascript-based project (and not every JS dev is familiar with the Ruby build tools).

julesfern commented 12 years ago

It's true, the build system is a filthy hodgepodge put together by me in a hurry. I'll create a fresh ticket to sort this out, and I agree in principle with the technology selection. Meanwhile, thanks for the push!