Add basic test - Githubissues

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.

MIT License

38 stars 9 forks source link

Add basic test #1

Closed rikhuijzer closed 2 years ago

rikhuijzer commented 2 years ago

Adds tests via a workflow in this repository.

rikhuijzer commented 2 years ago

Oops PR against wrong repo. This is still a work in progress.

rikhuijzer commented 2 years ago

The test almost works: https://github.com/rikhuijzer/cache-artifacts/pull/2. I'll fix it within a few days.

SaschaMann commented 2 years ago

Sounds great, please add yourself to the authors as well since you've already done more work than I have for this action :D

rikhuijzer commented 2 years ago

All tests pass now :partying_face: (see https://github.com/rikhuijzer/cache-artifacts/pull/2)

Some notes:

The tests are quite extensive now. I guess that that's good because it would be very unfortunate it if turns out that this action doesn't really cache artifacts properly. So, the tests cover outputs.cache-hit AND the actual artifacts folders
To ensure that each run stores a new cache, I've had to make the restore-keys more strict. The original idea of those keys was probably that the Artifacts system can handle files for different versions perfectly fine, so more files is better. I wonder now in what kind of situation these stricter restore-keys make a difference. I think it should be fine
@SaschaMann could you enable GitHub Actions on this repository?

SaschaMann commented 2 years ago

To ensure that each run stores a new cache, I've had to make the restore-keys more strict. The original idea of those keys was probably that the Artifacts system can handle files for different versions perfectly fine, so more files is better. I wonder now in what kind of situation these stricter restore-keys make a difference. I think it should be fine

I think originally they were based on the example GitHub provided rather than Julia-specific. Should be fine with stricter keys too.

@SaschaMann could you enable GitHub Actions on this repository?

Done

SaschaMann commented 2 years ago

Apparently closing and reopening doesn't trigger CI anymore, could you push an empty commit or so to trigger it?

rikhuijzer commented 2 years ago

Apparently closing and reopening doesn't trigger CI anymore, could you push an empty commit or so to trigger it?

Doesn't seem to work. I guess we first need to get this .github/workflow/ into main?

Tests passed again for a6f12e0, see https://github.com/rikhuijzer/cache-artifacts/pull/4.