search

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.
MIT License
38 stars 9 forks source link

add overridable `save-always` option #107

Open IanButterworth opened 10 months ago

IanButterworth commented 10 months ago

Closes #79

omus commented 10 months ago

Have you validated this is working? This failed CI run didn't seem to save the cache:

IanButterworth commented 10 months ago

It appears to be a CI glitch. CI had stalled and I did a partial re-run only of the failed jobs, which might not be valid for the test setup here.

There's a macos runner stalling here now too

IanButterworth commented 10 months ago

I've been meaning to test this on another repo with forced failure. I'll check before merge

IanButterworth commented 8 months ago

Yeah this is broken (never worked) upstream. PR to fix it https://github.com/actions/cache/pull/1325

IanButterworth commented 7 months ago

There's a staggering lack of review urgency on the upstream fix PR https://github.com/actions/cache/pull/1325

It makes me wonder if we should maintain a fork of actions/cache

omus commented 7 months ago

Based upon this comment the change to actions/cache@v4 should be considered breaking here. I think we'll be merging #123 first which means this change will be non-breaking for the upcoming release (v2).

IanButterworth commented 5 months ago

actions/cache are planning to remove the (non-working) save-always option which I think makes the goal of this PR impossible.

https://github.com/actions/cache/issues/1315#issuecomment-2163822166

DilumAluthge commented 2 months ago

Marking as draft until (if/when) the blockers in https://github.com/actions/cache/issues/1315#issuecomment-2163822166 become unblocked.