search

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.
MIT License
38 stars 8 forks source link

v1.2 broke Plots.jl CI #42

Closed simeonschaub closed 1 year ago

simeonschaub commented 1 year ago

Plots.jl CI started erroring with the following logs since the new release: https://github.com/JuliaPlots/Plots.jl/actions/runs/3859523069/jobs/6579133683#step:10:62. My initial suspicion came from a new environment variable PRECOMPILATION_CACHE_PATH appearing in CI logs, so maybe that has something to with the failures. Just downgrading the cache version to v1.1.7 did not fix the issue, probably because it was still using old cache files. For now, removing the caching step seems to work around the issue. (Ref https://github.com/JuliaPlots/Plots.jl/pull/4624)

giordano commented 1 year ago

Repo maintainers can cleanup CI cache at https://github.com/JuliaPlots/Plots.jl/actions/caches, but being sensitive to an environment variable called <WHATEVER>_PATH sounds like a problem in Plots CI

simeonschaub commented 1 year ago

I'm not familiar enough with Plots CI, but IIUC v1.2 only added a new option that's turned off by default, so it seems odd the new version broke this

rikhuijzer commented 1 year ago

Duplicate of https://github.com/julia-actions/cache/issues/10.

Sounds like a Conda.jl bug since it is also an issue if you would move the Julia directory from one system to the next.

t-bltg commented 1 year ago

FYI, we don't use Conda.jl but CondaPkg.jl in Plots (since the pyplot -> pythonplot transition). Looks like cleaning up the actions cache files fixed Plots CI.

SaschaMann commented 1 year ago

I'll close it since it doesn't look like we can do anything on the side of this action and it appears to be a duplicate of #10.

Feel free to reopen if you have a suggestion for something we can do, though.

timholy commented 1 year ago

I'm not familiar with how this works here, but if there's any chance that the cached precompile files might get out-of-sync with the settings used for precompilation in the rest of the project, that could be a concern. ENV variables can cause subtle problems, see see https://github.com/MakieOrg/Makie.jl/issues/2585#issuecomment-1381567065.

SaschaMann commented 1 year ago

The precompiled files aren't cached by default and the env vars shouldn't be accessed during compile time but we can take two precautions: