search

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.
MIT License
38 stars 9 forks source link

Replace commas in cache key to make actions/cache happy #92

Closed iamed2 closed 10 months ago

iamed2 commented 10 months ago

Now that matrix vars are included, it's more likely you'll run into commas in the cache key and get this error (assume [...] is a key with a comma):

Error: Key Validation Error: [...] cannot contain commas.

This restriction is not documented by GitHub but is checked here: https://github.com/actions/toolkit/blob/5430c5d84832076372990c7c27f900878ff66dc9/packages/cache/src/cache.ts#L32-L44

Ran into this in a private package using comma-separated lists in a value in the matrix.

IanButterworth commented 10 months ago

@omus do you see a simple fix?

omus commented 10 months ago

Fixed by: https://github.com/julia-actions/cache/pull/93