search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Update dependencies. #133

Closed sunoru closed 1 year ago

sunoru commented 1 year ago

The vulnerabilities warnings and deprecation warnings are fixed.

SaschaMann commented 1 year ago

Doesn't seem to be as straightforward as the deprecation warning suggests: src/setup-julia.ts(78,16): error TS2339: Property 'rmSync' does not exist on type 'typeof import("fs")'.

sunoru commented 1 year ago

Doesn't seem to be as straightforward as the deprecation warning suggests: src/setup-julia.ts(78,16): error TS2339: Property 'rmSync' does not exist on type 'typeof import("fs")'.

It is because the version of @types/node (v12) is too old but we are actually using node v16 on the ci

sunoru commented 1 year ago

I would like to turn this PR into bumping the dependency versions since many of them are too old and have vulnerabilities. Is that OK?

sunoru commented 1 year ago

And I don't understand why this was needed... https://github.com/julia-actions/setup-julia/pull/112

SaschaMann commented 1 year ago

And I don't understand why this was needed... https://github.com/julia-actions/setup-julia/pull/112

Because without it, npm install didn't work and this was the suggested fix in the error message.

sunoru commented 1 year ago

Nice, thank you for merging it!

And I don't understand why this was needed... #112

Because without it, npm install didn't work and this was the suggested fix in the error message.

Using --legacy-peer-deps would ignore a lot of dependency issues and I think it should be avoided 😂 (so I fixed them in this pr)

sunoru commented 1 year ago

BTW #119 can also be closed.