julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Pin node version to v16. Fix #135 #145

Closed sunoru closed 1 year ago

sunoru commented 1 year ago

Run the builds with Node v16 since v18 is the default on github action runners now (https://github.com/actions/runner-images/issues/7002). It will fix #135.

We can remove these lines whenever using: node18 is available: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions

DilumAluthge commented 1 year ago

What about users of this action? Do they need to do something to make sure that when they use the setup-julia action, that Node 16 will be used?

sunoru commented 1 year ago

No, they won't be affected at all. setup-julia always uses node v16 in users' actions as defined here

The issue of github defaulting to node v18 only caused our "Example builds" under this repo to fail.