search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Resolve `min` as the earliest compatible Julia version (compatible with the user's project) #202

Closed omus closed 1 month ago

omus commented 9 months ago

Introduces a special version ~"MIN"~ "min" which when passed in as the version allows the user to test against the earliest version of Julia compatible with their project. In order to determine this version the project file is read.

~If we want we can choose another name for this special version but I would like to keep the name short as this usually appears in the CI check name which can already be quite long.~

Update: We've decided on "min" as the special version name

omus commented 9 months ago

Did some basic local testing but need to add real tests before this is ready for review

DilumAluthge commented 9 months ago

Does this work for all julia = "..." compat entries, or just some? Can we document which ones it works for?

DilumAluthge commented 3 months ago

We should make sure that the case-convention in this PR is consistent with that in https://github.com/julia-actions/setup-julia/pull/234#issuecomment-2179549945

DilumAluthge commented 3 months ago

@omus Looks like there are some merge conflicts.

DilumAluthge commented 3 months ago

With #234 merged I think it makes sense to make this lowercase min

Seems reasonable to me.

IanButterworth commented 2 months ago

@omus do you agree with that change? I could take this PR over?

giordano commented 1 month ago

This should be reverted as soon as possible: #278. Edit: nevermind, #278 wasn't related to this PR.

IanButterworth commented 1 month ago

Should be fixed. Sorry. I forgot to update the tag to the tip of the release branch after missing adding that index file. (Our detailed dev docs need some additional check...)