search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Update node version #208

Closed giordano closed 6 months ago

giordano commented 8 months ago

Node 16 is deprecated https://github.com/julia-actions/setup-julia/blob/ffd1649f9b2d4d2608b754e0f5e24407f01d1960/action.yml#L26 https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

DilumAluthge commented 8 months ago

Quoting from my comment here:

Node20 requires glibc 2.28.

CentOS 7 ships with glibc 2.17. Therefore, once we upgrade julia-actions/setup-julia to Node20, self-hosted CentOS 7 runners won't be able to use new versions of the setup-julia action.

CentOS 7 will become end-of-life on June 30, 2024. Therefore, I think that we should wait until June 30 to upgrade setup-julia to Node20.

CentOS 8 ships with glibc 2.28. Therefore, self-hosted CentOS 8 runners will be able to run Node20.

WardBrian commented 8 months ago

GitHub is suggesting that node 16 support would be dropped before June:

Our plan is to transition all actions to run on Node 20 by Spring 2024

It would be great if v2 tag was published with node 20 support. People using runners that cannot run node 20 can stay on the previous major version, as they will currently also have to do with actions such as cache, upload-artifact, etc