search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Fix the Apple Silicon (macOS `aarch64` / `arm64`) URLs for Julia nightly #220

Closed benlorenz closed 8 months ago

benlorenz commented 8 months ago

Testing with julia nightly on macos-14 (aarch64) currently fails with:

Run julia-actions/setup-julia@v1
Download of https://julialangnightlies-s3.julialang.org/bin/mac/aarch64/julia-latest-mac64.tar.gz failed, trying again. Error: Error: Unexpected HTTP response: 404

The filename is slightly wrong and should have macaarch64 instead of mac64, this PR tries to fix this for linux and macOS. I also added macOS-14 (for the new M1 runners) to the nightly tests.

Note that these URLs are a bit of a guesswork. On the official nightly downloads page they have a different format using a slightly more homogeneous pattern (at least for linux and macos):

Edit: Looks like the new tests on the M1 were successful: https://github.com/julia-actions/setup-julia/actions/runs/7855176535/job/21436628690?pr=220#step:5:15

DilumAluthge commented 8 months ago

This is great, thank you @benlorenz! I'll take a look.

@SaschaMann It would be great if you could take a look too.

cc: @ViralBShah - once this is merged and a new release is made, we can use this in the SparseArrays.jl repo.

DilumAluthge commented 8 months ago

@SaschaMann or @IanButterworth If you have time, can you do a post-merge review?

ViralBShah commented 8 months ago

Nice! Is using juliaup to install Julia more reliable?

DilumAluthge commented 8 months ago

I don't think we need the added complexity of juliaup for this action.

IanButterworth commented 8 months ago

https://github.com/julia-actions/setup-julia/pull/221