Bump the version number to `2.0.0` in `package.json` and `package-lock.json`

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.

MIT License

93 stars 23 forks source link

Bump the version number to `2.0.0` in `package.json` and `package-lock.json` #228

Closed DilumAluthge closed 6 months ago

DilumAluthge commented 6 months ago

Follow-up to https://github.com/julia-actions/setup-julia/pull/209

IanButterworth commented 6 months ago

Did you manually edit package-lock.json? It's machine generated by npm install/build and there was a diff when I ran that (that I just pushed).

FWIW, PR style nit.. I find keeping the PR title short and general to the concept "Bump version to 2.0.0" and the detail getting refined in the PR/commits to be a smoother approach with less noise for people following along.

IanButterworth commented 6 months ago

I'm working on releasing this

DilumAluthge commented 6 months ago

I can run the release script when I get back to my computer, unless you beat me to it.

IanButterworth commented 6 months ago

https://github.com/julia-actions/setup-julia/releases/tag/v2.0.0

DilumAluthge commented 6 months ago

Narrator: he did indeed beat him to it

DilumAluthge commented 6 months ago

Thank you Ian!

IanButterworth commented 6 months ago

The script is a little bumpy for me. Notes:

This line in the build script fails on MacOS and messes up the rest of the script https://github.com/julia-actions/bin/blob/31b4b500a3f419f3aed06ba1aa640bb41fdb835f/build-release.sh#L33 Error: sed: 1: ".gitignore": invalid command code .
The script doesn't check you've got master checked out and up to date. I didn't at first, which resulted in a bad release branch being pushed with non-squashed commits. Then I couldn't fix it because delete and force push is disabled for release branches (I had to disable that momentarily for myself to fix it)