search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

Always print an error message, never error silently #262

Closed DilumAluthge closed 2 months ago

DilumAluthge commented 3 months ago

Ref #240 Ref #241

This PR does NOT fix the actual problem in #240 or #241, but it does fix the problem of setup-julia erroring silently and not printing a log message.

With this PR, as a general rule, we always print the error message before we throw the error.

DilumAluthge commented 2 months ago

Bump @IanButterworth @omus.

I think this PR is a strict improvement over the status quo, because (AFAICT) it makes sure that this action never errors without printing logs first.