search

julia-actions / setup-julia

This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
MIT License
93 stars 23 forks source link

[BUG] Error: File not found: '/home/runner/work/_actions/julia-actions/setup-julia/v2/dist/index.js' #278

Closed giordano closed 1 month ago

giordano commented 1 month ago

Describe the bug

This action is now broken

To Reproduce

      - uses: julia-actions/setup-julia@v2

Using version 2.4.0 just published

Expected behavior

The workflow doesn't crash immediately

Screenshots/Build logs

https://github.com/JuliaPackaging/JLLWrappers.jl/actions/runs/10636073649/job/29487082230?pr=67

Additional context

N/A

IanButterworth commented 1 month ago

Should be fixed now. Sorry. I forgot to update the tag to the tip of the release branch after missing adding that index file. (Our detailed dev docs need some additional check...)

giordano commented 1 month ago

Is there a way to automate whatever needs to be done to publish a new release?

IanButterworth commented 1 month ago

That'd be nice. The mistake I made was skipping a step in https://github.com/julia-actions/setup-julia/blob/master/devdocs/making_a_new_release.md#step-4-remove-the-dist-line-from-the-gitignore-file

The tip of that branch passed after I fixed it, but the tip wasn't where the tags were

giordano commented 1 month ago

Feels like all the instructions in that file should be a dispatch workflow so that you click a button and everything is done automatically.

IanButterworth commented 1 month ago

Indeed.

IanButterworth commented 1 month ago

Judging by https://github.com/JuliaPackaging/JLLWrappers.jl/pull/67 we can close this. Thanks for the fast report!

giordano commented 1 month ago

For example you could read the version number from package.json and automatically publish the version, I do something like that for a VS Code extension: https://github.com/oracc/nisaba/blob/0464b23c1af964f4fc5d0102a89ff51355b3c610/.github/workflows/tag.yml BTW, the version number is still 2.3.0: https://github.com/julia-actions/setup-julia/blob/014c323ee07f2f2de8e278a7e7be072719976b74/package.json#L3

IanButterworth commented 1 month ago

Yeah, our release notes don't handle when the version on master should be updated (https://github.com/julia-actions/setup-julia/pull/279)

TagBot has a similar thing to that https://github.com/JuliaRegistries/TagBot/actions/workflows/publish.yml